Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tpg v5)!: rule.rate_limit_options.enforce_on_key has not default value #77

Merged
merged 9 commits into from
Oct 24, 2023
Merged

fix(tpg v5)!: rule.rate_limit_options.enforce_on_key has not default value #77

merged 9 commits into from
Oct 24, 2023

Conversation

imrannayer
Copy link
Member

@imrannayer imrannayer commented Oct 17, 2023 •
edited
Loading

In 4.X, the default value for rule.rate_limit_options.enforce_on_key is ALL. In 5.X this field no longer has a default value. If you need All you will need to set it explicitly. See Rule 2 in examples/security-policy-all folder for reference.

@imrannayer imrannayer requested a review from a team as a code owner October 17, 2023 14:34
g-awmalik
g-awmalik reviewed Oct 17, 2023
View reviewed changes
Copy link

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor nits.

versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
examples/security-policy-all/versions.tf Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need versions.tf for examples?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infrequently, might be needed if the example make use a provider directly such as Random, etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we dont have any other provider except google, leme remove it.

apeabody
apeabody reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @imrannayer! Can you also lift to 6 in https://github.com/GoogleCloudPlatform/terraform-google-cloud-armor/blob/main/test/setup/versions.tf

versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
examples/security-policy-all/versions.tf Outdated Show resolved Hide resolved
@imrannayer imrannayer changed the title fix: upgraded versions.tf to include minor bumps from tpg v5 fix!: upgraded versions.tf to include minor bumps from tpg v5 Oct 17, 2023
@imrannayer imrannayer changed the title fix!: upgraded versions.tf to include minor bumps from tpg v5 fix(tpg v5)!: rule.rate_limit_options.enforce_on_key has not default value Oct 17, 2023
@imrannayer
Copy link
Member Author

imrannayer commented Oct 17, 2023 •
edited
Loading

@g-awmalik @apeabody This will be a breaking change as there is a behavior change for rule.rate_limit_options.enforce_on_key in 5.x.

@apeabody
Copy link
Contributor

@g-awmalik @apeabody This will be a breaking change as there is a behavior change for rule.rate_limit_options.enforce_on_key in 5.x.

Thanks @imrannayer - @g-awmalik any thoughts on releasing #70 as a final v4 compatible before merging this?

@imrannayer
Copy link
Member Author

@g-awmalik @apeabody This will be a breaking change as there is a behavior change for rule.rate_limit_options.enforce_on_key in 5.x.

Thanks @imrannayer - @g-awmalik any thoughts on releasing #70 as a final v4 compatible before merging this?

@apeabody #70 is already a breaking change. I think it will be better to release 5.X with it.

@apeabody
Copy link
Contributor

apeabody commented Oct 17, 2023 •
edited
Loading

@g-awmalik @apeabody This will be a breaking change as there is a behavior change for rule.rate_limit_options.enforce_on_key in 5.x.

Thanks @imrannayer - @g-awmalik any thoughts on releasing #70 as a final v4 compatible before merging this?

@apeabody #70 is already a breaking change. I think it will be better to release 5.X with it.

Just to confirm, the breaking change rule.rate_limit_options.enforce_on_key will also raise the minimum TPG to >= 5?

@imrannayer
Copy link
Member Author

@apeabody I am not changing min version to 5.X. Min is still 4.79. But in case anyone gets upgrade to 5.X will need to make sure they provide a value for rule.rate_limit_options.enforce_on_key.

@apeabody
Copy link
Contributor

@apeabody I am not changing min version to 5.X. Min is still 4.79. But in case anyone gets upgrade to 5.X will need to make sure they provide a value for rule.rate_limit_options.enforce_on_key.

Got it - Thanks!

@imrannayer
Copy link
Member Author

/gcbrun

@imrannayer
Copy link
Member Author

@g-awmalik can u plz approve this PR

g-awmalik
g-awmalik approved these changes Oct 24, 2023
View reviewed changes
examples/simple-example/versions.tf Outdated Show resolved Hide resolved
@imrannayer imrannayer merged commit a9a0198 into GoogleCloudPlatform:main Oct 24, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Oct 24, 2023
Merged
@imrannayer imrannayer mentioned this pull request Oct 26, 2023
Merged
@imrannayer imrannayer self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody left review comments

@g-awmalik g-awmalik g-awmalik approved these changes

Assignees

@imrannayer imrannayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imrannayer @apeabody @g-awmalik